On Tue, 7 Nov 2023 11:48:28 -0800 Reinette Chatre <reinette.chatre@xxxxxxxxx> wrote: > Hi Alex and Kevin, > > On 11/7/2023 12:29 AM, Tian, Kevin wrote: > >> From: Alex Williamson <alex.williamson@xxxxxxxxxx> > >> Sent: Friday, November 3, 2023 11:51 PM > >> > >> On Fri, 3 Nov 2023 07:23:13 +0000 > >> "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote: > >> > >>>> From: Alex Williamson <alex.williamson@xxxxxxxxxx> > >>>> Sent: Friday, November 3, 2023 5:14 AM > >>>> > >>>> On Thu, 2 Nov 2023 03:14:09 +0000 > >>>> "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote: > >>>> > >>>>>> From: Tian, Kevin > >>>>>> Sent: Thursday, November 2, 2023 10:52 AM > >>>>>> > >>>>>>> > >>>>>>> Without an in-tree user of this code, we're just chopping up code for > >>>>>>> no real purpose. There's no reason that a variant driver requiring > >> IMS > >>>>>>> couldn't initially implement their own SET_IRQS ioctl. Doing that > >>>>>> > >>>>>> this is an interesting idea. We haven't seen a real usage which wants > >>>>>> such MSI emulation on IMS for variant drivers. but if the code is > >>>>>> simple enough to demonstrate the 1st user of IMS it might not be > >>>>>> a bad choice. There are additional trap-emulation required in the > >>>>>> device MMIO bar (mostly copying MSI permission entry which > >> contains > >>>>>> PASID info to the corresponding IMS entry). At a glance that area > >>>>>> is 4k-aligned so should be doable. > >>>>>> > >>>>> > >>>>> misread the spec. the MSI-X permission table which provides > >>>>> auxiliary data to MSI-X table is not 4k-aligned. It sits in the 1st > >>>>> 4k page together with many other registers. emulation of them > >>>>> could be simple with a native read/write handler but not sure > >>>>> whether any of them may sit in a hot path to affect perf due to > >>>>> trap... > >>>> > >>>> I'm not sure if you're referring to a specific device spec or the PCI > >>>> spec, but the PCI spec has long included an implementation note > >>>> suggesting alignment of the MSI-X vector table and pba and separation > >>>> from CSRs, and I see this is now even more strongly worded in the 6.0 > >>>> spec. > >>>> > >>>> Note though that for QEMU, these are emulated in the VMM and not > >>>> written through to the device. The result of writes to the vector > >>>> table in the VMM are translated to vector use/unuse operations, which > >>>> we see at the kernel level through SET_IRQS ioctl calls. Are you > >>>> expecting to get PASID information written by the guest through the > >>>> emulated vector table? That would entail something more than a simple > >>>> IMS backend to MSI-X frontend. Thanks, > >>>> > >>> > >>> I was referring to IDXD device spec. Basically it allows a process to > >>> submit a descriptor which contains a completion interrupt handle. > >>> The handle is the index of a MSI-X entry or IMS entry allocated by > >>> the idxd driver. To mark the association between application and > >>> related handles the driver records the PASID of the application > >>> in an auxiliary structure for MSI-X (called MSI-X permission table) > >>> or directly in the IMS entry. This additional info includes whether > >>> an MSI-X/IMS entry has PASID enabled and if yes what is the PASID > >>> value to be checked against the descriptor. > >>> > >>> As you said virtualizing MSI-X table itself is via SET_IRQS and it's > >>> 4k aligned. Then we also need to capture guest updates to the MSI-X > >>> permission table and copy the PASID information into the > >>> corresponding IMS entry when using the IMS backend. It's MSI-X > >>> permission table not 4k aligned then trapping it will affect adjacent > >>> registers. > >>> > >>> My quick check in idxd spec doesn't reveal an real impact in perf > >>> critical path. Most registers are configuration/control registers > >>> accessed at driver init time and a few interrupt registers related > >>> to errors or administrative purpose. > >> > >> Right, it looks like you'll need to trap writes to the MSI-X > >> Permissions Table via a sparse mmap capability to avoid assumptions > >> whether it lives on the same page as the MSI-X vector table or PBA. > >> Ideally the hardware folks have considered this to avoid any conflict > >> with latency sensitive registers. > >> > >> The variant driver would use this for collecting the meta data relative > >> to the IMS interrupt, but this is all tangential to whether we > >> preemptively slice up vfio-pci-core's SET_IRQS ioctl or the iDXD driver > >> implements its own. > > > > Agree > > > >> > >> And just to be clear, I don't expect the iDXD variant driver to go to > >> extraordinary lengths to duplicate the core ioctl, we can certainly > >> refactor and export things where it makes sense, but I think it likely > >> makes more sense for the variant driver to implement the shell of the > >> ioctl rather than trying to multiplex the entire core ioctl with an ops > >> structure that's so intimately tied to the core implementation and > >> focused only on the MSI-X code paths. Thanks, > >> > > > > btw I'll let Reinette to decide whether she wants to implement such > > a variant driver or waits until idxd siov driver is ready to demonstrate > > the usage. One concern with the variant driver approach is lacking > > of a real-world usage (e.g. what IMS brings when guest only wants > > MSI-X on an assigned PF). Though it may provide a shorter path > > to enable the IMS backend support, also comes with the long-term > > maintenance burden. > > Thank you very much for your guidance and advice. > > I'd be happy to implement what is required for this work. Unfortunately > I am not confident that I understand what is meant with "variant driver". > > I initially understood "variant driver" to mean the planned IDXD virtual > device driver (the "IDXD VDCM" driver) that will assign IDXD resources > to guests with varying granularity and back the guest MSI-X interrupts > of these virtual devices with IMS interrupts on the host. From Kevin > I understand "variant driver" is a new sample driver for an IDXD > assigned PF, backing guest MSI-X interrupts with IMS interrupts on > the host. > > The IDXD VDCM driver is in progress. If a new variant driver needs to be > created then I still need to do some research in how to accomplish it. > Even so, it is not clear to me who the users of this new driver would be. > If the requirement is to demonstrate this VFIO IMS usage then we could > perhaps wait until the IDXD VDCM driver is ready and thus not have to deal > with additional maintenance burden. A vfio-pci variant driver is specifically a driver that leverages portions of vfio-pci-core for implementing vfio_device_ops and binds to a PCI device. It might actually be the wrong term here, but I jumped to that since the series tries to generalize portions of one of the vfio-pci-core code paths. You might very well be intending to use this with something more like an mdev driver, which is fine. That also sort of illustrates the point though that this series is taking a pretty broad approach to slicing up vfio-pci-core's SET_IRQS ioctl code path, enabling support for IMS backed interrupts, but in effect complicating the whole thing without any actual consumer to justify the complication. Meanwhile I think the goal is to reduce complication to a driver that doesn't exist yet. So it currently seems like a poor trade-off. This driver that doesn't exist yet could implement its own SET_IRQS ioctl that backs MSI-X with IMS as a starting point. Presumably we expect multiple drivers to require this behavior, so common code makes sense, but the rest of us in the community can't really evaluate how much it makes sense to slice the common code without seeing that implementation and how it might leverage, if not directly use, the existing core code. The sample drivers come into play in that if we were to make the vfio-pci-core SET_IRQS path usable in this generic way, then any driver implementing SET_IRQS for a PCI device should be able to take advantage of it, including those that already exist in samples/vfio-mdev/. I don't think anyone is requesting an iDXD sample driver, the real driver should be sufficient. > In the mean time there are items that I do understand better > and will work on right away: > - Do not have ops span the SET_IRQS ioctl() > - Use container_of() instead of opaque pointer > - Do not ignore INTx, consider the mdev sample driver when refactoring > this code. > - Consider the Intel vgpu driver as user of new emulated interrupt > interface. I think looking at kvmgt and the existing sample drivers to find commonality that actually provides simplification would be a good start, but I don't anticipate implementing IMS backed MSI-X in common code unless we're at least imminently able to make use of it. Thanks, Alex
