Re: [PATCH 1/1] s390/cio: make sch->lock a spinlock (is a pointer)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 11/1/23 12:57, Halil Pasic wrote:
The lock member of struct subchannel used to be a spinlock, but became
a pointer to a spinlock with commit 2ec2298412e1 ("[S390] subchannel
lock conversion."). This might have been justified back then, but with
the current state of affairs, there is no reason to manage a separate
spinlock object.

Let's simplify things and pull the spinlock back into struct subchannel.

Signed-off-by: Halil Pasic<pasic@xxxxxxxxxxxxx>
---
I know it is a lot of churn, but I do believe in the end it does make
the code more maintainable.

You are right. Makes the code easy to read and a bit less complex.
Looks good to me. Thanks

Reviewed-by: Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>

--snip--




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux