Re: [PATCH v2 1/1] KVM: s390: vsie: fix wrong VIR 37 when MSO is used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03.11.23 15:21, Claudio Imbrenda wrote:
On Thu, 2 Nov 2023 21:38:43 +0100
David Hildenbrand <david@xxxxxxxxxx> wrote:

[...]

   	/*
   	 * Only new shadow blocks are added to the list during runtime,
   	 * therefore we can safely reference them all the time.

Right, mso is 64bit, the prefix is 18bit (shifted by 13) -> 31bit.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

thanks


Does it make sense to remember the maximum prefix address across all
shadows (or if the mso was ever 0), so we can optimize for the mso == 0
case and not have to go through all vsie pages on all notification?
Sounds like a reasonable optimization on top.
yes, but it adds complexity to already complex code


Such an optimization would be very simplistic.

--
Cheers,

David / dhildenb





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux