On Fri, 3 Nov 2023 10:29:36 +0100 Nico Boehr <nrb@xxxxxxxxxxxxx> wrote: > Since we now have the ability to run guests without MSO/MSL, add a test > to make sure this doesn't break. [...] > + /* the guest will now write to an unmapped address and we check that this causes a segment translation exception */ > + report_prefix_push("guest write to unmapped"); > + expect_pgm_int(); > + sie(&vm); > + check_pgm_int_code(PGM_INT_CODE_SEGMENT_TRANSLATION); can you also check that the faulting address is the one we expect? > + report_prefix_pop(); > +} > + [...] > diff --git a/s390x/snippets/c/sie-dat.c b/s390x/snippets/c/sie-dat.c > new file mode 100644 > index 000000000000..e07136bf7430 > --- /dev/null > +++ b/s390x/snippets/c/sie-dat.c > @@ -0,0 +1,52 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Snippet used by the sie-dat.c test to verify paging without MSO/MSL > + * > + * Copyright (c) 2023 IBM Corp > + * > + * Authors: > + * Nico Boehr <nrb@xxxxxxxxxxxxx> > + */ > +#include <libcflat.h> > +#include <asm-generic/page.h> > +#include "sie-dat.h" > + > +static uint8_t test_page[GUEST_TEST_PAGE_COUNT * PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE))); I would call it test_pages [...]