Re: [PATCH] block: Free iovec arrays allocated by multiwrite_merge()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



<20100421183536.GG24351@xxxxxxxxxx>; from Ryan Harper on Wed, Apr 21, 2010 at 13:35:36 -0500
> * Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx> [2010-04-21 13:27]:
> > A new iovec array is allocated when creating a merged write request.
> > This patch ensures that the iovec array is deleted in addition to its
> > qiov owner.
> 
> Nice catch.  Send this to qemu-devel and Avi and merge into qemu-kvm
> once it's commited there.

Nice catch indeed.

Debugging with mtrace() also pointed to the iovec code as the culprit.

It's been running for 45 minutes with this patch applied - no leaks. Thanks!


-- 
Leszek "Tygrys" Urbanski, SCSA, SCNA
 "Unix-to-Unix Copy Program;" said PDP-1. "You will never find a more
  wretched hive of bugs and flamers. We must be cautious." -- DECWARS
     http://cygnus.moo.pl/ -- Cygnus High Altitude Balloon
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux