Hi drew,
thanks for coming back to me. I tried using "git-send-email" but was struggling with the SMTP configuration of my company (Microsoft Outlook online account...). So far I've not found a way to authenticate with SMTP, so I was unfortunately unable to send the patch (with improved rationale, as requested).
Since giving back to the open source community is more of a personal wish and is not required by management (but also not forbidden), it has low priority and I already spent some time on this. I will send patches in the future from my personal email account.
I am totally fine with someone else submitting the patch.
If it's not too inconvenient, could you please add a "reported-by" to the patch? (No problem if not)
Thank you.
Best Regards,
Matthias
________________________________________
From: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>
Sent: Tuesday, October 24, 2023 13:31
To: Matthias Rosenfelder
Cc: kvm@xxxxxxxxxxxxxxx; Andrew Jones; Alexandru Elisei; Eric Auger; kvmarm@xxxxxxxxxxxxxxx
Subject: Re: [kvm-unit-tests PATCH] arm: pmu: Fix overflow test condition
CAUTION! External Email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
On Fri, Sep 29, 2023 at 09:19:37PM +0000, Matthias Rosenfelder wrote:
> Hello,
>
> I think one of the test conditions for the KVM PMU unit test "basic_event_count" is not strong enough. It only checks whether an overflow occurred for counter #0, but it should also check that none happened for the other counter(s):
>
> report(read_sysreg(pmovsclr_el0) & 0x1,
> "check overflow happened on #0 only");
>
> This should be "==" instead of "&".
>
> Note that this test uses one more counter (#1), which must not overflow. This should also be checked, even though this would be visible through the "report_info()" a few lines above. But the latter does not mark the test failing - it is purely informational, so any test automation will not notice.
>
>
> I apologize in advance if my email program at work messes up any formatting. Please let me know and I will try to reconfigure and resend if necessary. Thank you.
Hey Matthias,
We let you know the formatting was wrong, but we haven't yet received a
resend. But, since Eric already reviewed it, I've gone ahead and applied
it to arm/queue with this fixes tag
Fixes: 4ce2a8045624 ("arm: pmu: Basic event counter Tests")
drew
[Banner]<http://www.nio.io>
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. You may NOT use, disclose, copy or disseminate this information. If you have received this email in error, please notify the sender and destroy all copies of the original message and all attachments. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
