On 10/26/23 13:12, Thomas Huth wrote:
On 26/10/2023 05.40, Shaoqin Huang wrote:
Add a new configure option "--dirty-ring-size" to support dirty-ring
migration on arm64. By default, the dirty-ring is disabled, we can
enable it by:
# ./configure --dirty-ring-size=65536
This will generate one more entry in config.mak, it will look like:
# cat config.mak
:
ACCEL=kvm,dirty-ring-size=65536
With this configure option, user can easy enable dirty-ring and specify
dirty-ring-size to test the dirty-ring in migration.
Do we really need a separate configure switch for this? If it is just
about setting a value in the ACCEL variable, you can also run the tests
like this:
ACCEL=kvm,dirty-ring-size=65536 ./run_tests.sh
Thomas
Hi Thomas,
You're right. We can do it by simply set the ACCEL when execute
./run_tests.sh. I think maybe add a configure can make auto test to set
the dirty-ring easier? but I'm not 100% sure it will benefit to them.
Thanks,
Shaoqin
--
Shaoqin
