On 21.04.2010, at 11:26, Avi Kivity wrote: > On 04/21/2010 09:07 AM, Takuya Yoshikawa wrote: >> Hi, Alex, Avi, Marcelo >> >> I would like to ask you about the commit: >> c8240bd6f0b4b1b21ffd36dd44114d05c7afe0c0 "Use Little Endian for Dirty Bitmap" >> I pasted a snipet below! >> >> I am now confused by the Alex's comment to my recent patch: >> "change mark_page_dirty() to handle endian issues explicitly" >> in which I open-coded the generic___set_le_bit(). >> >> So please explain me about the commit: >> 1. is this really the thing you intended to do? >> > > I think so. > >> 2. including<asm-generic/bitops/le.h> directly is OK? >> -- I made a sample patch to avoid this, see below. >> > > I don't see a problem with it, it is also included from other places. > > It might be possible to change it to <asm/bitops/le.h>, not sure how the include paths are set out. That's the great thing about being in-kernel :-). > >> 3. or, I misunderstand something about Alex's comment? >> > > I missed the comment. What was it? What comment? The reason was that longs and big endian don't match and I wanted to make it LE. This seemed like the right function to use, as other code in Linux uses it too. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
