On Tue, Apr 20, 2010 at 10:21:55AM +0800, Xin, Xiaohui wrote: > Michael, > > >>>>>> What we have not done yet: > >>>>>> packet split support > >>>>>> > >>>>>What does this mean, exactly? > >>>> We can support 1500MTU, but for jumbo frame, since vhost driver before don't > >>>>support mergeable buffer, we cannot try it for multiple sg. > >>>> > >>>I do not see why, vhost currently supports 64K buffers with indirect > >>>descriptors. > >>> > >> The receive_skb() in guest virtio-net driver will merge the multiple sg to skb frags, how >>can indirect descriptors to that? > > >See add_recvbuf_big. > > I don't mean this, it's for buffer submission. I mean when packet is received, in receive_buf(), mergeable buffer knows which pages received can be hooked in skb frags, it's receive_mergeable() which do this. > > When a NIC driver supports packet split mode, then each ring descriptor contains a skb and a page. When packet is received, if the status is not EOP, then hook the page of the next descriptor to the prev skb. We don't how many frags belongs to one skb. So when guest submit buffers, it should submit multiple pages, and when receive, the guest should know which pages are belongs to one skb and hook them together. I think receive_mergeable() can do this, but I don't see how big->packets handle this. May I miss something here? > > Thanks > Xiaohui Yes, I think this packet split mode probably maps well to mergeable buffer support. Note that 1. Not all devices support large packets in this way, others might map to indirect buffers better So we have to figure out how migration is going to work 2. It's up to guest driver whether to enable features such as mergeable buffers and indirect buffers So we have to figure out how to notify guest which mode is optimal for a given device 3. We don't want to depend on jumbo frames for decent performance So we probably should support GSO/GRO -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
