On 20/10/2023 15:43, Joao Martins wrote: > On 20/10/2023 00:59, Jason Gunthorpe wrote: >> On Thu, Oct 19, 2023 at 12:58:29PM +0100, Joao Martins wrote: >>> AMD has no such behaviour, though that driver per your earlier suggestion might >>> need to wait until -rc1 for some of the refactorings get merged. Hopefully we >>> don't need to wait for the last 3 series of AMD Driver refactoring (?) to be >>> done as that looks to be more SVA related; Unless there's something more >>> specific you are looking for prior to introducing AMD's domain_alloc_user(). >> >> I don't think we need to wait, it just needs to go on the cleaning list. >> > > I am not sure I followed. This suggests an post-merge cleanups, which goes in > different direction of your original comment? But maybe I am just not parsing it > right (sorry, just confused) > Oh, I think I now really understood what you originally meant. The wait was into other stuff that needs work unrelated to this, not specifically for these patches to wait e.g. stuff like domain_alloc_paging as your example, with respect to domain_alloc_user being reused as well and different domain types. I will follow-up with v5 shortly with both drivers.