On 20/10/2023 07:46, Tian, Kevin wrote:
>> From: Joao Martins <joao.m.martins@xxxxxxxxxx>
>> Sent: Thursday, October 19, 2023 4:27 AM
>>
>> +/**
>> + * enum iommufd_hw_info_capabilities
>> + * @IOMMU_CAP_DIRTY_TRACKING: IOMMU hardware support for dirty
>> tracking
>
> @IOMMU_HW_CAP_DIRTY_TRACKING: ...
>
OK
>> /**
>> * struct iommu_hw_info - ioctl(IOMMU_GET_HW_INFO)
>> * @size: sizeof(struct iommu_hw_info)
>> @@ -430,6 +438,8 @@ enum iommu_hw_info_type {
>> * the iommu type specific hardware information data
>> * @out_data_type: Output the iommu hardware info type as defined in the
>> enum
>> * iommu_hw_info_type.
>> + * @out_capabilities: Output the iommu capability info type as defined in
>> the
>> + * enum iommu_hw_capabilities.
>
> "Output the 'generic' iommu capability info ..."
>
Yeap, I 'generic' is important here
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Thanks
