On 20/10/2023 00:56, Jason Gunthorpe wrote: > On Thu, Oct 19, 2023 at 10:14:41AM +0100, Joao Martins wrote: > >>> We should also support setting dirty tracking even if the domain has not >>> been attached to any device? >>> >> Considering this rides on hwpt-alloc which attaches a device on domain >> allocation, then this shouldn't be possible in pratice. > > ?? It doesn't.. iommufd_hwpt_alloc() pass immediate_attach=false. The > immediate attach is only for IOAS created auto domains which can't > support dirty tracking I'm mixing the domain being created with a device that it can validate against vs actually ends up happening right after (in a separate operation) which is for the device to be attached to the domain via ATTACH_IOMMU_PT. So technically one can set dirty tracking on an empty domain. Joao
