On Mon, Sep 11, 2023, Jinrong Liang wrote: > From: Jinrong Liang <cloudliang@xxxxxxxxxxx> > > Add vcpu_set_cpuid_property() helper function for setting properties, > which simplifies the process of setting CPUID properties for vCPUs. > > Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx> > Signed-off-by: Jinrong Liang <cloudliang@xxxxxxxxxxx> > --- > .../selftests/kvm/include/x86_64/processor.h | 4 ++++ > tools/testing/selftests/kvm/lib/x86_64/processor.c | 14 ++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h > index 4fd042112526..6b146e1c6736 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/processor.h > +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h > @@ -973,6 +973,10 @@ static inline void vcpu_set_cpuid(struct kvm_vcpu *vcpu) > > void vcpu_set_cpuid_maxphyaddr(struct kvm_vcpu *vcpu, uint8_t maxphyaddr); > > +void vcpu_set_cpuid_property(struct kvm_vcpu *vcpu, > + struct kvm_x86_cpu_property property, > + uint32_t value); The vcpu_set_cpuid_maxphyaddr() helper right above this can and should be converted as part of this patch. X86_PROPERTY_MAX_PHY_ADDR is already defined, i.e. it's a trivial conversion, and that way there's an immediate user of the the new helper.