Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben: > From: David Woodhouse <dwmw@xxxxxxxxxxxx> > > There's no need to force the user to assign a vdev. We can automatically > assign one, starting at xvda and searching until we find the first disk > name that's unused. > > This means we can now allow '-drive if=xen,file=xxx' to work without an > explicit separate -driver argument, just like if=virtio. > > Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx> Actually, how does this play together with xen_config_dev_blk()? This looks like it tried to implement a very similar thing (which is IF_XEN even already existed). Are we now trying to attach each if=xen disk twice in the 'xenpv' machine? Or if something prevents this, is it dead code? I think in both cases, we would want to delete that function and remove the loop that calls it in xen_init_pv()? Kevin
