On 11.10.2023 15:57, Stefano Garzarella wrote: > On Tue, Oct 10, 2023 at 10:15:12PM +0300, Arseniy Krasnov wrote: >> Hello, >> >> this patchset contains second and third parts of another big patchset >> for MSG_ZEROCOPY flag support: >> https://lore.kernel.org/netdev/20230701063947.3422088-1-AVKrasnov@xxxxxxxxxxxxxx/ >> >> During review of this series, Stefano Garzarella <sgarzare@xxxxxxxxxx> >> suggested to split it for three parts to simplify review and merging: >> >> 1) virtio and vhost updates (for fragged skbs) (merged to net-next, see >> link below) >> 2) AF_VSOCK updates (allows to enable MSG_ZEROCOPY mode and read >> tx completions) and update for Documentation/. <-- this patchset >> 3) Updates for tests and utils. <-- this patchset >> >> Part 1) was merged: >> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=71b263e79370348349553ecdf46f4a69eb436dc7 >> >> Head for this patchset is: >> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=19537e125cc7cf2da43a606f5bcebbe0c9aea4cc >> >> Link to v1: >> https://lore.kernel.org/netdev/20230922052428.4005676-1-avkrasnov@xxxxxxxxxxxxxxxxx/ >> Link to v2: >> https://lore.kernel.org/netdev/20230930210308.2394919-1-avkrasnov@xxxxxxxxxxxxxxxxx/ >> Link to v3: >> https://lore.kernel.org/netdev/20231007172139.1338644-1-avkrasnov@xxxxxxxxxxxxxxxxx/ >> >> Changelog: >> v1 -> v2: >> * Patchset rebased and tested on new HEAD of net-next (see hash above). >> * See per-patch changelog after ---. >> v2 -> v3: >> * Patchset rebased and tested on new HEAD of net-next (see hash above). >> * See per-patch changelog after ---. >> v3 -> v4: >> * Patchset rebased and tested on new HEAD of net-next (see hash above). >> * See per-patch changelog after ---. > > I think I fully reviewed the series ;-) > > Tests are all passing here, including the new ones. I also added > vsock_perf and vsock_uring_test to my test suite! Thanks for review! > > So for vsock point of view everything looks fine. > > Let's see if there is anything about net (MSG_ZEROCOPY flags, etc.) Yes, let's wait for more comments, because whole patchset is R-b now and this finally completes MSG_ZEROCOPY support for virtio/vsock. Thanks, Arseniy > > Thanks, > Stefano >