On 10/4/2023 8:25 PM, Jason Gunthorpe wrote:
On Tue, Oct 03, 2023 at 04:04:21PM -0600, Alex Williamson wrote:
+/**
+ * ice_vfio_pci_load_state - VFIO device state reloading
+ * @ice_vdev: pointer to ice vfio pci core device structure
+ *
+ * Load device state and restore it. This function is called when the VFIO uAPI
+ * consumer wants to load the device state info from VFIO migration region and
+ * restore them into the device. This function should make sure all the device
+ * state info is loaded and restored successfully. As a result, return value is
+ * mandatory to be checked.
+ *
+ * Return 0 for success, negative value for failure.
+ */
Kudos on the kernel-doc comments throughout, nice!
This appears to be a substantial improvement from the comments I see
on v2, I'm curious where Kevin and Jason stand on this now. Thanks,
It is on my todo list, but I haven't been able to look
Did the fundamental issue with operating the VF from the VFIO driver
get fully fixed?
Jason
Yes, I think so. In this version, with Kevin's guidance and help, there
is not DMA read/write guest memory any more. VFIO driver will not
operate VF and guest memory.
You can refer to Patch10 for more details.
Thanks.
Yahui.
