On Fri, Oct 06, 2023 at 09:23:59AM +0000, Oliver Upton wrote: > On Fri, Oct 06, 2023 at 01:23:08AM +0100, Mark Brown wrote: > > That said I'm not 100% clear why this isn't being added to "make > > headers" and/or the perf build stuff? > Isn't 'make headers' just for UAPI headers though? Also, perf is just an Possibly, I didn't look closely. It'd certainly be more tasteful. > incidental user of this via cputype.h, KVM selftests is what's taking > the direct dependency. If perf doesn't care perhaps just restructure things so it doesn't pull it in and do whatever you were doing originally then? > > Surely if perf is happy to peer into the main kernel source it could > > just as well do the generation as part of the build? There's no great > > obstacle to having a target which runs the generation script that I > > can see. > That'd be less than ideal, IMO. tools maintaining a separate set of kernel > headers from the authoritative source avoids the need to coordinate > changes across kernel and tools. To keep things that way we either need > to copy the script+encoding or the header output. The latter isn't that > bothersome if/when we need an update. The error Stephen found was: | In file included from util/../../arch/arm64/include/asm/cputype.h:201, | from util/arm-spe.c:37: | tools/arch/arm64/include/asm/sysreg.h:132:10: fatal error: asm/sysreg-defs.h: No such file or directory so that's already happening - see perf's arm-spe.c. You could also fix perf by avoiding spelunking in the main kernel source like it's currently doing.
Attachment:
signature.asc
Description: PGP signature
