On Thu, Sep 28, 2023 at 07:32:38PM +0200, Lukas Wunner wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Component Measurement and Authentication (CMA, PCIe r6.1 sec 6.31) > allows for measurement and authentication of PCIe devices. It is > based on the Security Protocol and Data Model specification (SPDM, > https://www.dmtf.org/dsp/DSP0274). > +#define dev_fmt(fmt) "CMA: " fmt > +void pci_cma_init(struct pci_dev *pdev) > +{ > + struct pci_doe_mb *doe; > + int rc; > + > + if (!pci_cma_keyring) { > + return; > + } Jonathan mentioned the extra brackets below; here's another. > + if (!pdev->spdm_state) { > + return; > + } > + if (IS_ERR(pci_cma_keyring)) { > + pr_err("Could not allocate keyring\n"); There's a #define dev_fmt(fmt) above, but I don't think it's used in this patch. I think this would need something like: #define pr_fmt(fmt) "PCI: CMA: " fmt
