On Wed, Oct 04, 2023 at 10:40:45AM +0100, Marc Zyngier wrote: > On Wed, 04 Oct 2023 00:03:56 +0100, > Oliver Upton <oliver.upton@xxxxxxxxx> wrote: > > > > Few more fixes that I threw on top: > > > > v10 -> v11: > > - Drop the custom handling of FEAT_BC as it is now fixed on the arm64 > > side (Kristina) > > - Bikeshed on the naming of the masks ioctl to keep things in the KVM_ > > namespace > > - Apply more bikeshedding to the ioctl documentation, spinning off > > separate blocks for the 'generic' description and the Feature ID > > documentation > > - Fix referencing in the vCPU features doc > > - Fix use of uninitialized data in selftest > > We'll probably need another bit on top to deal with Kirstina's > FEAT_MOPS series and make that field writable. Yep, I was planning on a one-liner to unmask MOPS once I get Kristina's patches applied. > The minor nitpicks I had notwithstanding: > > Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx> Appreciated! -- Thanks, Oliver