Hi Matthias, On 9/29/23 23:19, Matthias Rosenfelder wrote: > Hello, > > I think one of the test conditions for the KVM PMU unit test "basic_event_count" is not strong enough. It only checks whether an overflow occurred for counter #0, but it should also check that none happened for the other counter(s): > > report(read_sysreg(pmovsclr_el0) & 0x1, > "check overflow happened on #0 only"); > > This should be "==" instead of "&". Your change indeed makes sense to match the comment. Please resubmit following Drew's hint and feel free to add my Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx> Thanks Eric > > Note that this test uses one more counter (#1), which must not overflow. This should also be checked, even though this would be visible through the "report_info()" a few lines above. But the latter does not mark the test failing - it is purely informational, so any test automation will not notice. > > > I apologize in advance if my email program at work messes up any formatting. Please let me know and I will try to reconfigure and resend if necessary. Thank you. > > Best Regards, > > Matthias > [Banner]<http://www.nio.io> > This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. You may NOT use, disclose, copy or disseminate this information. If you have received this email in error, please notify the sender and destroy all copies of the original message and all attachments. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
