[AMD Official Use Only - General] > -----Original Message----- > From: Nathan Chancellor <nathan@xxxxxxxxxx> > Sent: Monday, October 2, 2023 11:23 PM > To: Gupta, Nipun <Nipun.Gupta@xxxxxxx>; Agarwal, Nikhil > <nikhil.agarwal@xxxxxxx>; alex.williamson@xxxxxxxxxx > Cc: ndesaulniers@xxxxxxxxxx; trix@xxxxxxxxxx; Rohila, Shubham > <shubham.rohila@xxxxxxx>; kvm@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx; > patches@xxxxxxxxxxxxxxx; Nathan Chancellor <nathan@xxxxxxxxxx> > Subject: [PATCH] vfio/cdx: Add parentheses between bitwise AND expression > and logical NOT > > When building with clang, there is a warning (or error with > CONFIG_WERROR=y) due to a bitwise AND and logical NOT in > vfio_cdx_bm_ctrl(): > > drivers/vfio/cdx/main.c:77:6: error: logical not is only applied to the left hand > side of this bitwise operator [-Werror,-Wlogical-not-parentheses] > 77 | if (!vdev->flags & BME_SUPPORT) > | ^ ~ > drivers/vfio/cdx/main.c:77:6: note: add parentheses after the '!' to evaluate > the bitwise operator first > 77 | if (!vdev->flags & BME_SUPPORT) > | ^ > | ( ) > drivers/vfio/cdx/main.c:77:6: note: add parentheses around left hand side > expression to silence this warning > 77 | if (!vdev->flags & BME_SUPPORT) > | ^ > | ( ) > 1 error generated. > > Add the parentheses as suggested in the first note, which is clearly what was > intended here. > > Closes: https://github.com/ClangBuiltLinux/linux/issues/1939 > Fixes: 8a97ab9b8b31 ("vfio-cdx: add bus mastering device feature support") > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> > --- Acked-by: Nikhil Agarwal <nikhil.agarwal@xxxxxxx>
