Re: [PATCH 1/5] Add a global synchronization point for pvclock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/17/2010 09:48 PM, Avi Kivity wrote:


+static u64 last_value = 0;

Needs to be atomic64_t.

+
  cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
  {
      struct pvclock_shadow_time shadow;
      unsigned version;
      cycle_t ret, offset;
+    u64 last;


+    do {
+        last = last_value;

Otherwise, this assignment can see a partial update.

On a 32-bit guest, that is.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux