Re: [kvm-unit-tests PATCH] x86/apic: Gates test_pv_ipi on KVM cpuid, not test device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 26, 2023 at 6:08 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> Please keep the mailing list Cc'd so that other can participate in the conversation,
> and so that the mails are archived.

Sorry! I've now enabled reply-to-all by default so I can't forget again.

> > 2. Bring a copy of the necessary KVM uapi header file(s) into the
> > repo, slightly hacked up to cut down on transitive dependencies. It
> > looks like lib/linux/*.h might already be similar instances for other
> > Linux bits. Qemu also does this.
>
> This has my vote, though I'd strongly prefer not to strip out anything unless it's
> absolutely necessary to get KUT to compile.  Grabbing entire files should make it
> easier to maintain the copy+pasted code as future updates to re-sync will hopefully
> add just the new features.

Yup, makes sense.

> The attached half-baked patch adds everything except the base "is this KVM?"
> check and has only been compile tested on x86, feel free to use it as a starting
> point (I wanted to get the basic gist compiling to make sure I wasn't leading you
> completely astray)

The attachment doesn't seem to have made it, would you mind trying
again? Then I'll put together a v2 of the patch based on that.

Thanks,
Phil




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux