On 16.04.2010, at 11:25, Alexander Graf wrote: > > On 16.04.2010, at 11:22, Benjamin Herrenschmidt wrote: > >> On Fri, 2010-04-16 at 11:07 +0200, Alexander Graf wrote: >>> On 16.04.2010, at 08:47, Benjamin Herrenschmidt wrote: >>> >>>> On Fri, 2010-04-16 at 00:11 +0200, Alexander Graf wrote: >>>>> Our shadow MMU code needs to know where the HTAB is located and how >>>>> big it is. So we need some variables from the kernel exported to >>>>> module space if KVM is built as a module. >>>> >>>> Gross :-) Can't you just read the real SDR1 ? :-) >>> >>> I figured this is faster. >> >> In a fast path it might be, but I'm not too sure I like exporting >> those... Oh well, Ack for now, maybe we'll come up with something nicer >> at some stage. > > Well, I did look into reusing the existing functions for HTAB modification, but they're incredibly tightly coupled to Linux PTEs, partially even modifying them along the way. So this was a much much easier alternative. > > Of course, I guess I could do a mfsdr1 on init and just take it from there? The HTAB location shouldn't change right? Either way, please apply the patches as is. I'll do a cleanup later. PPC32 isn't exactly a heavily moving target :-). Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html