Re: [PATCH v2 3/4] KVM: x86: add more information to kvm_exit tracepoint

Subject: Re: [PATCH v2 3/4] KVM: x86: add more information to kvm_exit tracepoint
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Tue, 26 Sep 2023 18:40:03 +0200
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>
In-reply-to: <20230924124410.897646-4-mlevitsk@redhat.com>
References: <20230924124410.897646-1-mlevitsk@redhat.com> <20230924124410.897646-4-mlevitsk@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 9/24/23 14:44, Maxim Levitsky wrote:

+		__field(	bool,		guest_mode      )	     \
+		__field(	u64,		requests        )	     \
+		__field(	bool,		req_imm_exit	)	     \

I am not sure about adding guest_mode or req_imm_exit here, because theyshould always match kvm_entry.


Paolo

Follow-Ups:
- Re: [PATCH v2 3/4] KVM: x86: add more information to kvm_exit tracepoint
  - From: Maxim Levitsky

References:
- [PATCH v2 0/4] KVM: x86: tracepoint updates
  - From: Maxim Levitsky
- [PATCH v2 3/4] KVM: x86: add more information to kvm_exit tracepoint
  - From: Maxim Levitsky