> From: Baolu Lu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Thursday, September 21, 2023 9:31 AM > > On 9/20/23 9:10 PM, Liu, Yi L wrote: > >>>> + > >>>> + domain = iommu_domain_alloc(dev->bus); > >>> No need to bounce between core and driver. Just, > >>> > >>> intel_iommu_domain_alloc(IOMMU_DOMAIN_UNMANAGED); > >>> > >>> and fully initialize it before return. > >> If you are going to do that then intel_iommu_domain_alloc() should > >> fully initialize the domain, not here. > > I've also considered what Baolu described, but it requires to do some > > extra initialization which is duplicated with iommu_domain_alloc(). > > So I chose this simple way. > > Okay, got you. > Please add a comment for this temporary option.
