On Thu, 21 Sept 2023 at 08:25, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> wrote: > On 2023/06/19 21:19, Peter Maydell wrote: > > On Sat, 10 Jun 2023 at 04:51, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> wrote: > >> On 2022/12/01 20:00, Akihiko Odaki wrote: > >>> On 2022/12/01 19:40, Peter Maydell wrote: > >>>> On Thu, 1 Dec 2022 at 10:27, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> > >>>> wrote: > >>>>> A register access error typically means something seriously wrong > >>>>> happened so that anything bad can happen after that and recovery is > >>>>> impossible. > >>>>> Even failing one register access is catastorophic as > >>>>> architecture-specific code are not written so that it torelates such > >>>>> failures. > >>>>> > >>>>> Make sure the VM stop and nothing worse happens if such an error occurs. > >>>>> > >>>>> Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> > >> QEMU 8.0 is already released so I think it's time to revisit this. > > > > Two months ago would have been a better time :-) We're heading up > > towards softfreeze for 8.1 in about three weeks from now. > Hi Peter, > > Please apply this. Looking again at the patch I see it hasn't been reviewed by anybody on the KVM side of things. Paolo, does this seem like the right way to handle errors from kvm_arch_get_registers() and kvm_arch_put_registers() ? The original patch is at: https://patchew.org/QEMU/20221201102728.69751-1-akihiko.odaki@xxxxxxxxxx/ thanks -- PMM
