Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 21, 2023 at 09:16:21AM -0400, Michael S. Tsirkin wrote:

> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index bf0f54c24f81..5098418c8389 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22624,6 +22624,12 @@ L:	kvm@xxxxxxxxxxxxxxx
> >  S:	Maintained
> >  F:	drivers/vfio/pci/mlx5/
> >  
> > +VFIO VIRTIO PCI DRIVER
> > +M:	Yishai Hadas <yishaih@xxxxxxxxxx>
> > +L:	kvm@xxxxxxxxxxxxxxx
> > +S:	Maintained
> > +F:	drivers/vfio/pci/virtio
> > +
> >  VFIO PCI DEVICE SPECIFIC DRIVERS
> >  R:	Jason Gunthorpe <jgg@xxxxxxxxxx>
> >  R:	Yishai Hadas <yishaih@xxxxxxxxxx>
> 
> Tying two subsystems together like this is going to cause pain when
> merging. God forbid there's something e.g. virtio net specific
> (and there's going to be for sure) - now we are talking 3
> subsystems.

Cross subsystem stuff is normal in the kernel. Drivers should be
placed in their most logical spot - this driver exposes a VFIO
interface so it belongs here.

Your exact argument works the same from the VFIO perspective, someone
has to have code that belongs to them outside their little sphere
here.

> Case in point all other virtio drivers are nicely grouped, have a common
> mailing list etc etc.  This one is completely separate to the point
> where people won't even remember to copy the virtio mailing list.

The virtio mailing list should probably be added to the maintainers
enry

Jason



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux