Re: [PATCH] KVM: arm64: selftests: Add arch_timer_edge_cases selftest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Colton,

On 2023/9/16 0:04, Colton Lewis wrote:
It's been a few months with no comment on this. Can someone please
review? There was no need to rebase from the original patch. It's all
new code so there are no conflicts.

I understand it's a bigger patch, but I believe it all falls under the
same functional umbrella.

Thanks for your efforts. I'd like to give it a go but this patch fails
to compile on the mainline kernel.

In file included from include/aarch64/delay.h:9,
                from lib/aarch64/gic_v3.c:10:
include/aarch64/arch_timer.h: In function 'timer_get_tval':
include/aarch64/arch_timer.h:107:3: warning: implicit declaration of function 'GUEST_ASSERT_1'; did you mean 'GUEST_ASSERT_NE'? [-Wimplicit-function-declaration]
 107 |   GUEST_ASSERT_1(0, timer);
     |   ^~~~~~~~~~~~~~
     |   GUEST_ASSERT_NE

... and something like that. It'd be good if you could have a look.

Thanks,
Zenghui



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux