On Thu, 7 Sep 2023 18:16:52 +0100, Alexandru Elisei wrote:
> The first two patches revert "virtio-net: Don't print the compat warning
> for the default device" because using --network mode=none disables the
> device and lets the user know that it can use that to disable the default
> virtio-net device. I don't think the changes are controversial.
>
> And the last patch is there to get the conversation going about changing
> what --nodefaults does. Details in the patch.
>
> [...]
Applied first two to kvmtool (master), thanks!
[1/3] Revert "virtio-net: Don't print the compat warning for the default device"
https://git.kernel.org/will/kvmtool/c/4498eb7400c6
[2/3] builtin-run: Document mode=none for -n/--network
https://git.kernel.org/will/kvmtool/c/c7b7a542cdcd
I'm also not sure about the final RFC patch:
[3/3] builtin-run: Have --nodefaults disable the default virtio-net device
so it would be great to hear if anybody else has an opinion on that. IIRC,
we introduced this for some EFI work, so perhaps those folks might have
an opinion?
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
