On Mon, Apr 12, 2010 at 8:03 AM, pradeep <psuriset@xxxxxxxxxxxxxxxxxx> wrote: > sudhir kumar wrote: > >> On Fri, Apr 9, 2010 at 2:40 PM, pradeep <psuriset@xxxxxxxxxxxxxxxxxx> wrote: >> >>> Hi Lucas >>> >>> Thanks for your comments. >>> Please find the patch, with suggested changes. >>> >>> Thanks >>> Pradeep >>> >>> >>> >>> Signed-off-by: Pradeep Kumar Surisetty <psuriset@xxxxxxxxxxxxxxxxxx> >>> --- >>> diff -uprN autotest-old/client/tests/kvm/tests/balloon_check.py >>> autotest/client/tests/kvm/tests/balloon_check.py >>> --- autotest-old/client/tests/kvm/tests/balloon_check.py 1969-12-31 >>> 19:00:00.000000000 -0500 >>> +++ autotest/client/tests/kvm/tests/balloon_check.py 2010-04-09 >>> 12:33:34.000000000 -0400 >>> @@ -0,0 +1,47 @@ >>> +import re, string, logging, random, time >>> +from autotest_lib.client.common_lib import error >>> +import kvm_test_utils, kvm_utils >>> + >>> +def run_balloon_check(test, params, env): >>> + """ >>> + Check Memory ballooning: >>> + 1) Boot a guest >>> + 2) Increase and decrease the memory of guest using balloon command from >>> monitor >>> >> Better replace this description by "Change the guest memory between X >> and Y values" >> Also instead of using 0.6 and 0.95 below, better use two variables and >> take their value from config file. This will give the user a >> flexibility to narrow or widen the ballooning range. >> > Thanks for your suggestions. I dont think, user should need flexibility > here. > If ballooning doest work for one set of value, it will not work for any > other. > And here, we are choosing between 60 to 95% of actual values, which is > reasonable. Sorry for not having commented on this before. Yes, a reasonable, hardcoded range is completely OK to me. Did you tested and verified that this range is safe for guest testing? I mean, a memory set too low might trigger OOM killer on VMs, so I was wondering if 60% isn't too low... -- Lucas -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
