On Sat, 2023-08-26 at 00:14 +1200, Kai Huang wrote: > With keeping TDMRs upon successful TDX module initialization, now > only > put_online_mems() and freeing the buffers of the TDSYSINFO_STRUCT and > the CMR array still need to be done even when module initialization > is > successful. On the other hand, all other four "out_*" labels before > them explicitly check the return value and only clean up when module > initialization fails. > > This isn't ideal. Make all other four "out_*" labels only reachable > when module initialization fails to improve the readibility of error ^ Nit: "readability" > handling. Rename them from "out_*" to "err_*" to reflect the fact. > > Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>