On Thu, Sep 14, 2023 at 09:32:31AM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 14 Sep 2023 09:32:31 +0200 > From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > Subject: Re: [PATCH v4 04/21] hw/cpu: Update the comments of nr_cores and > nr_dies > > On 14/9/23 09:21, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@xxxxxxxxx> > > > > In the nr_threads' comment, specify it represents the > > number of threads in the "core" to avoid confusion. > > > > Also add comment for nr_dies in CPUX86State. > > > > Signed-off-by: Zhao Liu <zhao1.liu@xxxxxxxxx> > > --- > > Changes since v3: > > * The new patch split out of CPUSTATE.nr_cores' fix. (Xiaoyao) > > --- > > include/hw/core/cpu.h | 2 +- > > target/i386/cpu.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > Thanks! -Zhao