12.09.2023 14:30, Philippe Mathieu-Daudé:
kvm-stub.c only defines kvm_openpic_connect_vcpu(),
which is clearly not used by user emulation.
Yes, kvm-stub only defines this function. But you also move kvm.c
from ppc_ss to ppc_system_ss, and the commit message does not say
a word about this. Hopefully there's no usage of symbols in kvm.c
in other configurations (or else it wont link).
I think commit message might be just a bit more verbose. Right now
it is misleading/confusing, which is worse than no commit message
at all :)
For the changes,
Reviewed-by: Michael Tokarev <mjt@xxxxxxxxxx>
I even tried to build some targets (ppc user and system on x86)
with this change, but I can't say I verified every configuration.
/mjt
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
target/ppc/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/meson.build b/target/ppc/meson.build
index 4c2635039e..bf1c9319fa 100644
--- a/target/ppc/meson.build
+++ b/target/ppc/meson.build
@@ -30,7 +30,6 @@ gen = [
]
ppc_ss.add(when: 'CONFIG_TCG', if_true: gen)
-ppc_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
ppc_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user_only_helper.c'))
ppc_system_ss = ss.source_set()
@@ -46,6 +45,7 @@ ppc_system_ss.add(when: 'CONFIG_TCG', if_true: files(
), if_false: files(
'tcg-stub.c',
))
+ppc_system_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
ppc_system_ss.add(when: 'TARGET_PPC64', if_true: files(
'compat.c',
