11.09.2023 14:56, Stefan Hajnoczi:
Or instead of using linker behavior, maybe just change the #ifdef so it only applies when KVM is disabled. I didn't look at the code to see if this is possible, but it would be nice to avoid the very specific #ifdef condition in this patch.
Yeah, this is definitely preferrable to define it based on !kvm instead of !optimize. I mean the same thing when replied in the pullreq which broke things, - to base it on !kvm. But use something very similar to what Philippe did with the functions themselves (not with the condition). /mjt