Hi Philippe, On Mon, 28 Aug 2023 18:00:54 +0100, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > Hi Marc, > > On 28/8/23 17:31, Marc Zyngier wrote: > > Marek reports that his RPi4 spits out a warning at boot time, > > right at the point where the GICv2 virtual CPU interface gets > > mapped. > > > > Upon investigation, it seems that we never return the allocated > > VA and use whatever was on the stack at this point. Yes, this > > is good stuff, and Marek was pretty lucky that he ended-up with > > a VA that intersected with something that was already mapped. > > > > On my setup, this random value is plausible enough for the mapping > > to take place. Who knows what happens... > > > > Cc: Vincent Donnefort <vdonnefort@xxxxxxxxxx> > > Fixes: f156a7d13fc3 ("KVM: arm64: Remove size-order align in the nVHE hyp private VA range") > > I don't see your kvmarm-6.6 merged by Paolo, is it too late to squash > and send a new PR? In general, I keep the commits that are in -next stable (no squashing, no rebasing), and only the merge commits that drag these commits onto -next are throw-away (this allows me to rebuild the whole branch without changing any of the commit SHAs). So no, I won't send a new PR right now. However, I'll stick the patch in -next and will aim to send Paolo another PR later this week or early next week. > Anyhow: > > Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> Thanks! M. -- Without deviation from the norm, progress is not possible.