> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Friday, August 25, 2023 10:30 AM > > @@ -468,21 +469,31 @@ struct iommu_fault_event { > * struct iommu_fault_param - per-device IOMMU fault data > * @handler: Callback function to handle IOMMU faults at device level > * @data: handler private data > - * @faults: holds the pending faults which needs response > * @lock: protect pending faults list > + * @dev: the device that owns this param > + * @queue: IOPF queue > + * @queue_list: index into queue->devices > + * @partial: faults that are part of a Page Request Group for which the last > + * request hasn't been submitted yet. could clarify that it's protected by dev_iommu lock. Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>