Re: [awilliam-vfio:next 41/50] drivers/net/ethernet/amd/pds_core/auxbus.c:18: warning: Function parameter or member 'pf' not described in 'pds_client_register'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/17/2023 1:32 PM, kernel test robot wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


tree:   https://github.com/awilliam/linux-vfio.git next
head:   a881b496941f02fe620c5708a4af68762b24c33d
commit: b021d05e106e14b603a584b38ce62720e7d0f363 [41/50] pds_core: Require callers of register/unregister to pass PF drvdata
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230818/202308180411.OSqJPtMz-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308180411.OSqJPtMz-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308180411.OSqJPtMz-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/net/ethernet/amd/pds_core/auxbus.c:18: warning: Function parameter or member 'pf' not described in 'pds_client_register'
drivers/net/ethernet/amd/pds_core/auxbus.c:18: warning: Excess function parameter 'pf_pdev' description in 'pds_client_register'
drivers/net/ethernet/amd/pds_core/auxbus.c:58: warning: Function parameter or member 'pf' not described in 'pds_client_unregister'
drivers/net/ethernet/amd/pds_core/auxbus.c:58: warning: Excess function parameter 'pf_pdev' description in 'pds_client_unregister'


vim +18 drivers/net/ethernet/amd/pds_core/auxbus.c

4569cce43bc61e Shannon Nelson 2023-04-19   8
10659034c62273 Shannon Nelson 2023-04-19   9  /**
10659034c62273 Shannon Nelson 2023-04-19  10   * pds_client_register - Link the client to the firmware
10659034c62273 Shannon Nelson 2023-04-19  11   * @pf_pdev:      ptr to the PF driver struct
10659034c62273 Shannon Nelson 2023-04-19  12   * @devname:      name that includes service into, e.g. pds_core.vDPA
10659034c62273 Shannon Nelson 2023-04-19  13   *
10659034c62273 Shannon Nelson 2023-04-19  14   * Return: 0 on success, or
10659034c62273 Shannon Nelson 2023-04-19  15   *         negative for error
10659034c62273 Shannon Nelson 2023-04-19  16   */
b021d05e106e14 Brett Creeley  2023-08-07  17  int pds_client_register(struct pdsc *pf, char *devname)
10659034c62273 Shannon Nelson 2023-04-19 @18  {
10659034c62273 Shannon Nelson 2023-04-19  19    union pds_core_adminq_comp comp = {};
10659034c62273 Shannon Nelson 2023-04-19  20    union pds_core_adminq_cmd cmd = {};
10659034c62273 Shannon Nelson 2023-04-19  21    int err;
10659034c62273 Shannon Nelson 2023-04-19  22    u16 ci;
10659034c62273 Shannon Nelson 2023-04-19  23
10659034c62273 Shannon Nelson 2023-04-19  24    cmd.client_reg.opcode = PDS_AQ_CMD_CLIENT_REG;
10659034c62273 Shannon Nelson 2023-04-19  25    strscpy(cmd.client_reg.devname, devname,
10659034c62273 Shannon Nelson 2023-04-19  26            sizeof(cmd.client_reg.devname));
10659034c62273 Shannon Nelson 2023-04-19  27
10659034c62273 Shannon Nelson 2023-04-19  28    err = pdsc_adminq_post(pf, &cmd, &comp, false);
10659034c62273 Shannon Nelson 2023-04-19  29    if (err) {
10659034c62273 Shannon Nelson 2023-04-19  30            dev_info(pf->dev, "register dev_name %s with DSC failed, status %d: %pe\n",
10659034c62273 Shannon Nelson 2023-04-19  31                     devname, comp.status, ERR_PTR(err));
10659034c62273 Shannon Nelson 2023-04-19  32            return err;
10659034c62273 Shannon Nelson 2023-04-19  33    }
10659034c62273 Shannon Nelson 2023-04-19  34
10659034c62273 Shannon Nelson 2023-04-19  35    ci = le16_to_cpu(comp.client_reg.client_id);
10659034c62273 Shannon Nelson 2023-04-19  36    if (!ci) {
10659034c62273 Shannon Nelson 2023-04-19  37            dev_err(pf->dev, "%s: device returned null client_id\n",
10659034c62273 Shannon Nelson 2023-04-19  38                    __func__);
10659034c62273 Shannon Nelson 2023-04-19  39            return -EIO;
10659034c62273 Shannon Nelson 2023-04-19  40    }
10659034c62273 Shannon Nelson 2023-04-19  41
10659034c62273 Shannon Nelson 2023-04-19  42    dev_dbg(pf->dev, "%s: device returned client_id %d for %s\n",
10659034c62273 Shannon Nelson 2023-04-19  43            __func__, ci, devname);
10659034c62273 Shannon Nelson 2023-04-19  44
10659034c62273 Shannon Nelson 2023-04-19  45    return ci;
10659034c62273 Shannon Nelson 2023-04-19  46  }
10659034c62273 Shannon Nelson 2023-04-19  47  EXPORT_SYMBOL_GPL(pds_client_register);
10659034c62273 Shannon Nelson 2023-04-19  48
10659034c62273 Shannon Nelson 2023-04-19  49  /**
10659034c62273 Shannon Nelson 2023-04-19  50   * pds_client_unregister - Unlink the client from the firmware
10659034c62273 Shannon Nelson 2023-04-19  51   * @pf_pdev:      ptr to the PF driver struct
10659034c62273 Shannon Nelson 2023-04-19  52   * @client_id:    id returned from pds_client_register()
10659034c62273 Shannon Nelson 2023-04-19  53   *
10659034c62273 Shannon Nelson 2023-04-19  54   * Return: 0 on success, or
10659034c62273 Shannon Nelson 2023-04-19  55   *         negative for error
10659034c62273 Shannon Nelson 2023-04-19  56   */
b021d05e106e14 Brett Creeley  2023-08-07  57  int pds_client_unregister(struct pdsc *pf, u16 client_id)
10659034c62273 Shannon Nelson 2023-04-19 @58  {
10659034c62273 Shannon Nelson 2023-04-19  59    union pds_core_adminq_comp comp = {};
10659034c62273 Shannon Nelson 2023-04-19  60    union pds_core_adminq_cmd cmd = {};
10659034c62273 Shannon Nelson 2023-04-19  61    int err;
10659034c62273 Shannon Nelson 2023-04-19  62
10659034c62273 Shannon Nelson 2023-04-19  63    cmd.client_unreg.opcode = PDS_AQ_CMD_CLIENT_UNREG;
10659034c62273 Shannon Nelson 2023-04-19  64    cmd.client_unreg.client_id = cpu_to_le16(client_id);
10659034c62273 Shannon Nelson 2023-04-19  65
10659034c62273 Shannon Nelson 2023-04-19  66    err = pdsc_adminq_post(pf, &cmd, &comp, false);
10659034c62273 Shannon Nelson 2023-04-19  67    if (err)
10659034c62273 Shannon Nelson 2023-04-19  68            dev_info(pf->dev, "unregister client_id %d failed, status %d: %pe\n",
10659034c62273 Shannon Nelson 2023-04-19  69                     client_id, comp.status, ERR_PTR(err));
10659034c62273 Shannon Nelson 2023-04-19  70
10659034c62273 Shannon Nelson 2023-04-19  71    return err;
10659034c62273 Shannon Nelson 2023-04-19  72  }
10659034c62273 Shannon Nelson 2023-04-19  73  EXPORT_SYMBOL_GPL(pds_client_unregister);
10659034c62273 Shannon Nelson 2023-04-19  74

:::::: The code at line 18 was first introduced by commit
:::::: 10659034c622738bc1bfab8a76fc576c52d5acce pds_core: add the aux client API

:::::: TO: Shannon Nelson <shannon.nelson@xxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Fixing this now... Should have a patch up shortly.

Thanks,

Brett



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux