On Wed, Jun 14, 2023 at 7:41 PM Robert Hoo <robert.hoo.linux@xxxxxxxxx> wrote: > > Agree, and how about one step further, i.e. adjust the param's sequence. > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2c276d4d0821..db2bc5d3e2c2 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2992,7 +2992,7 @@ static int next_segment(unsigned long len, int offset) > */ > static int __kvm_read_guest_page(struct kvm_memory_slot *slot, > struct kvm_vcpu *vcpu, > - gfn_t gfn, void *data, int offset, int len) > + gfn_t gfn, int offset, void *data, int len) There are a lot of functions/callsites in kvm_main.c which use the "offset, data, len" convention. I'd prefer to switch them all at the same time for consistency, but I think that's too large of a change to splice in here: so I'll leave it as is for now.
