On Fri, 11 Aug 2023 17:29:11 +0800 Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote: > The driver init/exit() function don't do anything special, it > can use the module_fsl_mc_driver() macro to eliminate boilerplate > code. > > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > --- > drivers/vfio/fsl-mc/vfio_fsl_mc.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) Your colleague submitted a nearly identical patch, but also removing the redundant module owner, 2 days ago: https://lore.kernel.org/all/20230809131536.4021639-1-lizetao1@xxxxxxxxxx/ Thanks, Alex > > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > index f2140e94d41e..8053f13c2be5 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > @@ -604,19 +604,7 @@ static struct fsl_mc_driver vfio_fsl_mc_driver = { > }, > .driver_managed_dma = true, > }; > - > -static int __init vfio_fsl_mc_driver_init(void) > -{ > - return fsl_mc_driver_register(&vfio_fsl_mc_driver); > -} > - > -static void __exit vfio_fsl_mc_driver_exit(void) > -{ > - fsl_mc_driver_unregister(&vfio_fsl_mc_driver); > -} > - > -module_init(vfio_fsl_mc_driver_init); > -module_exit(vfio_fsl_mc_driver_exit); > +module_fsl_mc_driver(vfio_fsl_mc_driver); > > MODULE_LICENSE("Dual BSD/GPL"); > MODULE_DESCRIPTION("VFIO for FSL-MC devices - User Level meta-driver");
