On Thu, Aug 10, 2023, Anish Moorthy wrote: > I figured I'd start double checking my documentation changes before > sending out the next version, since those have been a persistent > issue. So, here's what I've currently got for the commit message here > > > hva_to_pfn_fast() currently just fails for read faults where > > establishing writable mappings is forbidden, which is unnecessary. > > Instead, try getting the page without passing FOLL_WRITE. This allows > > the aforementioned faults to (potentially) be resolved without falling > > back to slow GUP. Looks good! One nit, I would drop the "read" part of "read faults". This behavior also applies to executable faults. You captured the key part well (writable mappings forbidden), so I don't think there's any need to further clarify what types of faults this applies to.
