On 8/9/23 01:20, Sean Christopherson wrote:
/* - * It should be impossible for the hypervisor timer to be in - * use before KVM has ever run the vCPU. + * Don't bother switching APIC timer emulation from the + * hypervisor timer to the software timer, the only way for the + * APIC timer to be active is if userspace stuffed vCPU state, + * i.e. put the vCPU into a nonsensical state. Only an INIT + * will transition the vCPU out of UNINITIALIZED (without more + * state stuffing from userspace), which will reset the local + * APIC and thus smother the timer anyways, i.e. the APIC timer
"Cancel" is probably more understandable to non-native speakers, though undoubtedly less poetic.
Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Paolo
+ * IRQ(s) will be dropped no matter what. */ - WARN_ON_ONCE(kvm_lapic_hv_timer_in_use(vcpu)); -
