> From: Stefan Hajnoczi <stefanha@xxxxxxxxxx> > Sent: Thursday, August 10, 2023 5:03 AM > > @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info { > __u32 flags; > #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info > */ > #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ > - __u64 iova_pgsizes; /* Bitmap of supported page sizes */ > + __aligned_u64 iova_pgsizes; /* Bitmap of supported page > sizes */ > __u32 cap_offset; /* Offset within info struct of first cap */ > + __u32 reserved; isn't this conflicting with the new 'pad' field introduced in your another patch " [PATCH v3] vfio: align capability structures"? @@ -1304,6 +1305,7 @@ struct vfio_iommu_type1_info { #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ __u64 iova_pgsizes; /* Bitmap of supported page sizes */ __u32 cap_offset; /* Offset within info struct of first cap */ + __u32 pad; };