On 8/9/23 11:26, Arnd Bergmann wrote: > On Wed, Aug 9, 2023, at 18:54, Daniel Sneddon wrote: >> HI Arnd, >> >> On 8/9/23 06:05, Arnd Bergmann wrote: >>> From: Arnd Bergmann <arnd@xxxxxxxx> >>> >>> The declaration got placed in the .c file of the caller, but that >>> causes a warning for the definition: >>> >>> arch/x86/kernel/cpu/bugs.c:682:6: error: no previous prototype for 'gds_ucode_mitigated' [-Werror=missing-prototypes] >> >> When I build with gcc 9.4 and the x86_64_defconfig I don't see this warning even >> without this patch. I'm curious why you're seeing it and I'm not. Any ideas? > > The warning is currently disabled by default, unless you build with > 'make W=1'. I'm in the process of getting my last patches out to > change this so the warning is enabled by default though, so I was > phrasing this based on the future behavior. Sorry if this was confusing. > > Arnd That explains why I wasn't seeing it. Feel free to add: Tested-by: Daniel Sneddon <daniel.sneddon@xxxxxxxxxxxxxxx> Thanks, Dan
