On Tue, 8 Aug 2023 10:09:37 +0800
Li Zetao <lizetao1@xxxxxxxxxx> wrote:
> The cdx_driver_register() will set "THIS_MODULE" to driver.owner when
> register a cdx_driver driver, so it is redundant initialization to set
> driver.owner in the statement. Remove it for clean code.
>
> Signed-off-by: Li Zetao <lizetao1@xxxxxxxxxx>
> ---
> drivers/vfio/cdx/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vfio/cdx/main.c b/drivers/vfio/cdx/main.c
> index c376a69d2db2..de56686581ae 100644
> --- a/drivers/vfio/cdx/main.c
> +++ b/drivers/vfio/cdx/main.c
> @@ -223,7 +223,6 @@ static struct cdx_driver vfio_cdx_driver = {
> .match_id_table = vfio_cdx_table,
> .driver = {
> .name = "vfio-cdx",
> - .owner = THIS_MODULE,
> },
> .driver_managed_dma = true,
> };
Doesn't vfio_fsl_mc_driver have the same issue?
#define fsl_mc_driver_register(drv) \
__fsl_mc_driver_register(drv, THIS_MODULE)
static struct fsl_mc_driver vfio_fsl_mc_driver = {
.probe = vfio_fsl_mc_probe,
.remove = vfio_fsl_mc_remove,
.driver = {
.name = "vfio-fsl-mc",
.owner = THIS_MODULE,
},
.driver_managed_dma = true,
};
That driver could also be converted to use module_driver(). Thanks,
Alex
