On Thu, 27 Jul 2023 at 08:31, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> wrote: > > An error may occur after s->as is allocated, for example while > determining KVM type. That's about the one example you don't want to cite, because it makes it sound like this is only a problem because of a bug in the previous patch. In fact we already have lots of 'goto err' paths after the allocation of s->as, such as the one when kvm_ioctl(KVM_CREATE_VM) fails. > Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> > --- > accel/kvm/kvm-all.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index 94a62efa3c..4591669d78 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -2765,6 +2765,7 @@ err: > if (s->fd != -1) { > close(s->fd); > } > + g_free(s->as); > g_free(s->memory_listener.slots); > > return ret; Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx> thanks -- PMM