On Wed, Aug 02, 2023, Sean Christopherson wrote: > Oh, and no need to post "KVM: selftests: Rename the ASSERT_EQ macro" in the next > version, I'm planning on grabbing that one straightaway. After paging this all back in... I would much prefer that we implement the KVM specific macros[*], e.g. KVM_ONE_VCPU_TEST(), and build on top of those. I'm definitely ok doing a "slow" conversion, i.e. starting with a few easy tests. IIRC at some point I said I strongly preferred an all-or-nothing approach, but realistically I don't think we'll make progress anytime soon if we try to boil the ocean. But I do think we should spend the time to implement the infrastructure right away. We may end up having to tweak the infrastructure down the road, e.g. to convert other tests, but I would rather do that then convert some tests twice. [*] https://lore.kernel.org/all/Y2v+B3xxYKJSM%2FfH@xxxxxxxxxx
