On Tue, Apr 06, 2010 at 12:38:00AM +0300, Avi Kivity wrote: > On 04/05/2010 09:44 PM, Marcelo Tosatti wrote: > >On Thu, Mar 25, 2010 at 05:02:56PM +0200, Avi Kivity wrote: > >>Log emulated instructions in ftrace, especially if they failed. > >Why not log all emulated instructions? Seems useful to me. > > > > That was the intent, but it didn't pan out. I tried to avoid > double-logging where an mmio read is dispatched to userspace, and > the instruction is re-executed. > > Perhaps we should split it into a decode trace and execution result > trace? Less easy to use but avoids confusion due to duplication. I don't think duplication introduces confusion, as long as one can see rip on the trace entry (the duplication can actually be useful). -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
