On Thu, Jul 27, 2023 at 1:04 PM, David Woodhouse wrote: > On Wed, 2023-07-26 at 13:07 -0700, Sean Christopherson wrote: > > On Tue, Jul 25, 2023, David Woodhouse wrote: > > > On Fri, 2023-05-26 at 13:32 -0700, Sean Christopherson wrote: > > > > : Aha! And QEMU appears to have Xen emulation support. That means KVM-Unit-Tests > > > > : is an option. Specifically, extend the "access" test to use this hypercall instead > > > > : of INVLPG. That'll verify that the flush is actually being performed as expteced. > > > > > > That works. Metin has a better version that actually sets up the > > > hypercall page properly and uses it, but that one bails out when Xen > > > support isn't present, and doesn't show the failure mode quite so > > > clearly. This is the simple version: > > > > IIUC, y'all have already written both tests, so why not post both? I certainly > > won't object to more tests if they provide different coverage. > > Yeah, it just needed cleaning up. > > This is what we have; Metin will submit it for real after a little more > polishing. It modifies the existing access test so that *if* it's run > in a Xen environment, and *if* the HVMOP_flush_tlbs call returns > success instead of -ENOSYS, it'll use that instead of invlpg. Patch is posted to kvm-unit-tests: https://marc.info/?l=kvm&m=169052867024191&w=2 > In itself, that doesn't give us an automatic regression tests, because > you still need to run it manually — as before, > qemu-system-x86_64 -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -device pci-testdev --accel kvm,xen-version=0x4000a,kernel-irqchip=split -kernel ~/access_test.flat > > If we really want to, we can look at making it run that way when qemu > and the host kernel support Xen guests...?
