RE: [PATCH v4 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Monday, July 24, 2023 7:00 PM
> 
> --- a/drivers/iommu/iommufd/device.c
> +++ b/drivers/iommu/iommufd/device.c
> @@ -8,6 +8,7 @@
> 
>  #include "io_pagetable.h"
>  #include "iommufd_private.h"
> +#include "iommufd_test.h"

Is it stale?

> @@ -211,7 +213,7 @@ FIXTURE_SETUP(iommufd_ioas)
> 
>  	for (i = 0; i != variant->mock_domains; i++) {
>  		test_cmd_mock_domain(self->ioas_id, &self->stdev_id,
> -				     &self->hwpt_id, NULL);
> +				     &self->hwpt_id, &self->device_id);
>  		self->base_iova = MOCK_APERTURE_START;
>  	}
>  }
> @@ -290,6 +292,19 @@ TEST_F(iommufd_ioas, ioas_area_auto_destroy)
>  	}
>  }
> 
> +TEST_F(iommufd_ioas, get_hw_info)
> +{
> +	struct iommu_test_hw_info info;
> +
> +	if (self->device_id) {
> +		test_cmd_get_hw_info(self->device_id, sizeof(info), &info);
> +		assert(info.test_reg ==
> IOMMU_HW_INFO_SELFTEST_REGVAL);
> +	} else {
> +		test_err_get_hw_info(ENOENT, self->device_id,
> +				     sizeof(info), &info);
> +	}

If self->device_id is invalid it should be reported right after
test_cmd_mock_domain()?




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux